Skip to content

QCLINUX: arm64: dts: qcom: talos: Add GMSL deserializer and sensor#643

Merged
Salendarsingh Gaud (sgaud-quic) merged 1 commit into
qualcomm-linux:qcom-6.18.yfrom
mmitkovquicinc:6.18
Jun 18, 2026
Merged

QCLINUX: arm64: dts: qcom: talos: Add GMSL deserializer and sensor#643
Salendarsingh Gaud (sgaud-quic) merged 1 commit into
qualcomm-linux:qcom-6.18.yfrom
mmitkovquicinc:6.18

Conversation

@mmitkovquicinc

Copy link
Copy Markdown

Adds deserializer and camera sensor nodes to the Talos device tree. Talos features a single GMSL deserializer and exposes a single GMSL camera.

CRs-Fixed: 4555961

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No Change Task Found

No associated change tasks found for CR 4555961 on any of the following entities:

Entities:

  • kernel.qli.2.0

CR: 4555961

Please ensure the CR has a change task associated with at least one of the entities for this branch.

@qlijarvis

Copy link
Copy Markdown

PR #643 — validate-patch

PR: #643

Verdict Issues Detailed Report
N/A 0 Full report

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit
Verdict: N/A — click to expand

🔍 Patch Validation

PR: #643 - QCLINUX: arm64: dts: qcom: talos: Add GMSL deserializer and sensor
Upstream commit: N/A (vendor-only commit)
Verdict: ⏭️ SKIP (validation not applicable)

Commit Message

Check Status Note
Subject matches upstream N/A QCLINUX: prefix — vendor-only commit
Body preserves rationale N/A No upstream source to compare
Fixes tag present/correct N/A No Fixes tag; not a bugfix
Authorship preserved N/A Original vendor commit
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/talos-camera-sensor.dtsi N/A Vendor-specific device tree additions

Issues

None — this is a vendor-only commit with the correct QCLINUX: prefix.

Verdict

This commit uses the QCLINUX: prefix, indicating it is vendor-only code with no upstream equivalent. Validation against lore.kernel.org is not applicable. The commit adds GMSL deserializer and camera sensor device tree nodes specific to the Talos platform, which is appropriate for vendor-specific hardware enablement.

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit

@qlijarvis

Copy link
Copy Markdown

PR #643 — checker-log-analyzer

PR: #643
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26755526533

Checker Result Summary
Checker Result Summary
checkpatch 1 warning: undocumented DT compatible string
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check Graph port errors: missing #address-cells/#size-cells, reg format, missing binding
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance QCLINUX: prefix not in allowed list
tag-check Subject has valid prefix (QCLINUX:)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #643 — QCLINUX: arm64: dts: qcom: talos: Add GMSL deserializer and sensor
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/26755526533
Target branch: qcom-6.18.y

Checker Result Summary
checkpatch 1 warning: undocumented DT compatible string
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check Graph port errors: missing #address-cells/#size-cells, reg format, missing binding
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance QCLINUX: prefix not in allowed list
tag-check Subject has valid prefix (QCLINUX:)

❌ checkpatch

Root cause: Compatible string "qcom,cam-gmsl-sensor" is not documented in vendor-prefixes.yaml or a binding file.

Failure details:

WARNING: DT compatible string "qcom,cam-gmsl-sensor" appears un-documented -- check ./Documentation/devicetree/bindings/
#69: FILE: arch/arm64/boot/dts/qcom/talos-camera-sensor.dtsi:188:
+		compatible = "qcom,cam-gmsl-sensor";

58c21cb357950cec8f3dc19a3ae92ec98ff08bab total: 0 errors, 1 warnings, 0 checks, 60 lines checked

Fix: Add a device tree binding YAML for qcom,cam-gmsl-sensor in Documentation/devicetree/bindings/media/ or the appropriate subsystem directory. If this is a vendor-specific compatible string with no upstream binding, the warning can be noted but may not block merge for vendor-only branches.

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git b7cce9a3884a873855693af8591d4c9c469cd17e..58c21cb357950cec8f3dc19a3ae92ec98ff08bab

❌ dtb-check

Root cause: The port@0 node under qcom,cam-gmsl-deserializer0 is missing explicit #address-cells and #size-cells properties, causing graph port validation failures and reg format mismatches.

Failure details:

talos-camera-sensor.dtsi:178:4-14: Warning (reg_format): 
  /fragment@0/__overlay__/qcom,cci@ac4a000/qcom,cam-gmsl-deserializer0/port@0:reg: 
  property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)

talos-camera-sensor.dtsi:177:10-182:5: Warning (avoid_default_addr_size): 
  /fragment@0/__overlay__/qcom,cci@ac4a000/qcom,cam-gmsl-deserializer0/port@0: 
  Relying on default #address-cells value

talos-camera-sensor.dtsi:177:10-182:5: Warning (graph_port): 
  /fragment@0/__overlay__/qcom,cci@ac4a000/qcom,cam-gmsl-deserializer0/port@0: 
  graph node '#address-cells' is -1, must be 1

talos-camera-sensor.dtsi:177:10-182:5: Warning (graph_port): 
  /fragment@0/__overlay__/qcom,cci@ac4a000/qcom,cam-gmsl-deserializer0/port@0: 
  graph node '#size-cells' is -1, must be 0

arch/arm64/boot/dts/qcom/qcs615-ride-camx.dtb: 
  qcom,cci@ac4a000 (qcom,cci): qcom,cam-gmsl-deserializer0: 'ranges' is a required property

arch/arm64/boot/dts/qcom/qcs615-ride-camx.dtb: 
  qcom,cci@ac4a000 (qcom,cci): qcom,cam-gmsl-sensor0: 'ranges' is a required property

arch/arm64/boot/dts/qcom/qcs615-ride-camx.dtb: 
  /soc@0/qcom,cci@ac4a000/qcom,cam-gmsl-sensor0: 
  failed to match any schema with compatible: ['qcom,cam-gmsl-sensor']

Fix:

  1. Add explicit #address-cells and #size-cells to the port node in arch/arm64/boot/dts/qcom/talos-camera-sensor.dtsi:177:

    +	qcom,cam-gmsl-deserializer0 {
    +		...
    +		port@0 {
    +			#address-cells = <1>;
    +			#size-cells = <0>;
    +			reg = <0>;
    +			...
    +		};
    +	};
  2. Add ranges property to qcom,cam-gmsl-deserializer0 and qcom,cam-gmsl-sensor0 nodes if they have child nodes with reg properties. If no address translation is needed, use ranges; (empty).

  3. Add a binding YAML for qcom,cam-gmsl-sensor in Documentation/devicetree/bindings/ to resolve the "failed to match any schema" error.

Reproduce locally:

make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/talos-evk-camx.dtb
make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/qcs615-ride-camx.dtb

❌ check-patch-compliance

Root cause: The commit subject uses the QCLINUX: prefix, which is not in the checker's allowed list (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:).

Failure details:

Checking commit: QCLINUX: arm64: dts: qcom: talos: Add GMSL deserializer and sensor
Commit summary does not start with a required prefix

Fix: This is a known limitation of the check-patch-compliance checker. The QCLINUX: prefix is a vendor-internal tag used for vendor-only changes with no upstream equivalent. The checker enforces only upstream-linkable prefixes.

Options:

  • If this patch has been posted upstream or is derived from an upstream patch, change the prefix to FROMLIST: or UPSTREAM: and add a Link: tag pointing to the lore.kernel.org URL.
  • If this is genuinely a vendor-only change, the checker will always fail. This is expected behavior for vendor-only commits and does not indicate a patch defect.

Note: For vendor-only branches, this failure can be accepted as a known limitation.


✅ tag-check

Status: PASS

Analysis: The target branch is qcom-6.18.y, which is not qcom-next or qcom-next-staging, so the subject-prefix check is mandatory. The commit subject starts with QCLINUX:, which is a valid prefix tag. ✅


Verdict

3 blockers must be fixed before merge:

  1. dtb-check (critical): Add #address-cells = <1>; #size-cells = <0>; to the port@0 node and add ranges properties to parent nodes as required by the binding.
  2. dtb-check (critical): Add a device tree binding YAML for qcom,cam-gmsl-sensor to resolve the "failed to match any schema" error.
  3. checkpatch (warning): Document the qcom,cam-gmsl-sensor compatible string in a binding file (same as Adding Email Checker  #2).

Non-blocker:

  • check-patch-compliance: The QCLINUX: prefix failure is a known checker limitation for vendor-only commits. If this is a vendor-only change, this failure is expected and can be accepted.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add CRs-Fixed: 4555961 to git hub PR description . you can remove from commit log.

@qlijarvis

Copy link
Copy Markdown

PR #643 — validate-patch

PR: #643

Verdict Issues Detailed Report
0 Full report

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit
Verdict: ✅ — click to expand

🔍 Patch Validation

PR: #643 - QCLINUX: arm64: dts: qcom: talos: Add GMSL deserializer and sensor
Upstream commit: N/A (vendor-only QCLINUX: commit)
Verdict: ✅ PASS

Commit Message

Check Status Note
Subject matches upstream N/A QCLINUX: vendor-only commit
Body preserves rationale Clear description of hardware addition
Fixes tag present/correct N/A New feature, not a fix
Authorship preserved Milen Mitkov mmitkov@qti.qualcomm.com
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/talos-camera-sensor.dtsi Adds GMSL deserializer and sensor nodes; additive change only

Verdict

Merge as-is. This is a well-formed vendor-only device tree addition with proper commit message structure, clear rationale, and correct authorship.

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit

@qlijarvis

Copy link
Copy Markdown

PR #643 — checker-log-analyzer

PR: #643
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26755526533

Checker Result Summary
Checker Result Summary
checkpatch Undocumented DT compatible string warning
dt-binding-check No changes in bindings
dtb-check Multiple DT validation errors: missing #address-cells/#size-cells, invalid reg format, missing ranges property, no schema match
sparse-check ⏭️ Skipped (no C code changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance Subject prefix violation: "QCLINUX:" not allowed
tag-check N/A Not applicable for this branch
qcom-next-check N/A Not applicable for this branch

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #643 - QCLINUX: arm64: dts: qcom: talos: Add GMSL deserializer and sensor
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/26755526533

Checker Result Summary
checkpatch Undocumented DT compatible string warning
dt-binding-check No changes in bindings
dtb-check Multiple DT validation errors: missing #address-cells/#size-cells, invalid reg format, missing ranges property, no schema match
sparse-check ⏭️ Skipped (no C code changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance Subject prefix violation: "QCLINUX:" not allowed
tag-check N/A Not applicable for this branch
qcom-next-check N/A Not applicable for this branch

❌ checkpatch

Root cause: The compatible string "qcom,cam-gmsl-sensor" is used in the device tree but has no corresponding binding documentation.

Failure details:

WARNING: DT compatible string "qcom,cam-gmsl-sensor" appears un-documented -- check ./Documentation/devicetree/bindings/
#69: FILE: arch/arm64/boot/dts/qcom/talos-camera-sensor.dtsi:188:
+		compatible = "qcom,cam-gmsl-sensor";

58c21cb357950cec8f3dc19a3ae92ec98ff08bab total: 0 errors, 1 warnings, 0 checks, 60 lines checked

Fix: Add a device tree binding document for qcom,cam-gmsl-sensor in Documentation/devicetree/bindings/media/ or use an existing documented compatible string if this device is already supported.

Reproduce locally:

./scripts/checkpatch.pl --strict --summary-file --ignore FILE_PATH_CHANGES --git b7cce9a3884a873855693af8591d4c9c469cd17e..5180f850d259271e12db75a1ef8f637d342a1b02

❌ dtb-check

Root cause: The port@0 node in qcom,cam-gmsl-deserializer0 is missing required #address-cells and #size-cells properties, causing graph port validation failures and schema mismatches.

Failure details:

../arch/arm64/boot/dts/qcom/talos-camera-sensor.dtsi:178.4-14: Warning (reg_format): /fragment@0/__overlay__/qcom,cci@ac4a000/qcom,cam-gmsl-deserializer0/port@0:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)

../arch/arm64/boot/dts/qcom/talos-camera-sensor.dtsi:177.10-182.5: Warning (avoid_default_addr_size): /fragment@0/__overlay__/qcom,cci@ac4a000/qcom,cam-gmsl-deserializer0/port@0: Relying on default #address-cells value

../arch/arm64/boot/dts/qcom/talos-camera-sensor.dtsi:177.10-182.5: Warning (graph_port): /fragment@0/__overlay__/qcom,cci@ac4a000/qcom,cam-gmsl-deserializer0/port@0: graph node '#address-cells' is -1, must be 1

../arch/arm64/boot/dts/qcom/talos-camera-sensor.dtsi:177.10-182.5: Warning (graph_port): /fragment@0/__overlay__/qcom,cci@ac4a000/qcom,cam-gmsl-deserializer0/port@0: graph node '#size-cells' is -1, must be 0

/opt/actions-runner/_work/kernel-config/kernel-config/kernel/temp-out/arch/arm64/boot/dts/qcom/qcs615-ride-camx.dtb: qcom,cci@ac4a000 (qcom,cci): qcom,cam-gmsl-deserializer0: 'ranges' is a required property

arch/arm64/boot/dts/qcom/qcs615-ride-camx.dtb: /soc@0/qcom,cci@ac4a000/qcom,cam-gmsl-sensor0: failed to match any schema with compatible: ['qcom,cam-gmsl-sensor']

Fix:

  1. Add #address-cells = <1>; and #size-cells = <0>; to the qcom,cam-gmsl-deserializer0 node (parent of port@0)
  2. Add ranges; property to both qcom,cam-gmsl-deserializer0 and qcom,cam-gmsl-sensor0 nodes to satisfy the CCI bus schema requirements
  3. Ensure the port@0 node's reg property uses a single cell value (e.g., reg = <0>;) consistent with the parent's address/size cells

Example fix for arch/arm64/boot/dts/qcom/talos-camera-sensor.dtsi:147:

qcom,cam-gmsl-deserializer0 {
	cell-index = <2>;
	#address-cells = <1>;
	#size-cells = <0>;
	ranges;
	/* ... other properties ... */
	
	port@0 {
		reg = <0>;
		deser0_port0: endpoint {
			remote-endpoint = <&gmsl_sensor0_ep>;
		};
	};
};

qcom,cam-gmsl-sensor0 {
	cell-index = <3>;
	compatible = "qcom,cam-gmsl-sensor";
	ranges;
	/* ... other properties ... */
};

Reproduce locally:

make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/media/

❌ check-patch-compliance

Root cause: The commit subject uses the "QCLINUX:" prefix, which is not an allowed prefix for Qualcomm Linux kernel commits.

Failure details:

Checking commit: QCLINUX: arm64: dts: qcom: talos: Add GMSL deserializer and sensor
Commit summary does not start with a required prefix

Fix: Change the subject prefix from QCLINUX: to one of the allowed prefixes. For device tree changes, use:

  • FROMLIST: if the patch is posted to an upstream mailing list but not yet merged
  • UPSTREAM: if the patch is already merged in an upstream tree (mainline, linux-next, or subsystem tree)
  • BACKPORT: if cherry-picking from an upstream release
  • No prefix if this is a downstream-only change for qcom-next or qcom-next-staging branches

For this case, since it appears to be a downstream device tree addition, either:

  1. Remove the QCLINUX: prefix entirely if targeting qcom-next/qcom-next-staging
  2. Use FROMLIST: if you plan to upstream this change and have posted it to devicetree@vger.kernel.org

Reproduce locally:

# Check the commit message format
git log --oneline -1 58c21cb357950cec8f3dc19a3ae92ec98ff08bab

Verdict

3 blockers must be fixed before merge:

  1. checkpatch: Add DT binding documentation for qcom,cam-gmsl-sensor or use an existing compatible string
  2. dtb-check: Fix device tree structure by adding required #address-cells, #size-cells, and ranges properties
  3. check-patch-compliance: Remove or replace the QCLINUX: subject prefix with an allowed prefix

The dtb-check failures are the most critical as they indicate structural issues with the device tree that will cause runtime validation warnings. The missing binding documentation should be added to properly document the hardware interface.

@qcomlnxci

Copy link
Copy Markdown

Test Matrix

Test Case lemans-evk monaco-evk qcs615-ride qcs6490-rb3gen2 qcs8300-ride qcs9100-ride-r3 x1e80100-crd
BT_FW_KMD_Service ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
BT_ON_OFF ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
BT_SCAN ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
CPUFreq_Validation ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
CPU_affinity ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
DSP_AudioPD ✅ Pass ✅ Pass ⚠️ skip ✅ Pass ✅ Pass ⚠️ skip ◻️
Ethernet ⚠️ skip ✅ Pass ⚠️ skip ⚠️ skip ⚠️ skip ⚠️ skip ◻️
Freq_Scaling ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
GIC ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
IPA ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
Interrupts ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
OpenCV ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
PCIe ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
Probe_Failure_Check ❌ Fail ❌ Fail ✅ Pass ❌ Fail ❌ Fail ❌ Fail ◻️
RMNET ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
UFS_Validation ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
USBHost ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ◻️
WiFi_Firmware_Driver ❌ Fail ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
WiFi_OnOff ✅ Pass ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
adsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
cdsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
gpdsp_remoteproc ✅ Pass ✅ Pass ⚠️ skip ⚠️ skip ✅ Pass ❌ Fail ◻️
hotplug ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
irq ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
kaslr ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
pinctrl ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
qcom_hwrng ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
rngtest ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
shmbridge ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
smmu ❌ Fail ✅ Pass ❌ Fail ✅ Pass ✅ Pass ❌ Fail ◻️
watchdog ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
wpss_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️

@mmitkovquicinc

Copy link
Copy Markdown
Author

qli-2.0 GA pull-request freeze

@qcomlnxci

Copy link
Copy Markdown

Test Matrix

Test Case lemans-evk monaco-evk qcs615-ride qcs6490-rb3gen2 qcs8300-ride qcs9100-ride-r3 x1e80100-crd
BT_FW_KMD_Service ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
BT_ON_OFF ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
BT_SCAN ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
CPUFreq_Validation ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
CPU_affinity ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
DSP_AudioPD ✅ Pass ✅ Pass ⚠️ skip ✅ Pass ✅ Pass ⚠️ skip ◻️
Ethernet ⚠️ skip ✅ Pass ⚠️ skip ⚠️ skip ⚠️ skip ⚠️ skip ◻️
Freq_Scaling ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
GIC ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
IPA ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
Interrupts ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
OpenCV ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
PCIe ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
Probe_Failure_Check ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ◻️
RMNET ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
UFS_Validation ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
USBHost ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ◻️
WiFi_Firmware_Driver ❌ Fail ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
WiFi_OnOff ✅ Pass ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
adsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
cdsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
gpdsp_remoteproc ✅ Pass ✅ Pass ⚠️ skip ⚠️ skip ✅ Pass ❌ Fail ◻️
hotplug ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
irq ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
kaslr ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
pinctrl ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
qcom_hwrng ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
rngtest ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
shmbridge ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
smmu ❌ Fail ✅ Pass ❌ Fail ✅ Pass ✅ Pass ❌ Fail ◻️
watchdog ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
wpss_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️

@qlijarvis

Copy link
Copy Markdown

PR #643 — validate-patch

PR: #643

Verdict Issues Detailed Report
⚠️ 0 Full report

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #643
Title: QCLINUX: arm64: dts: qcom: talos: Add GMSL deserializer and sensor
Upstream commit: N/A (vendor-only patch)
Verdict: ⚠️ PARTIAL

Commit Message

Check Status Note
Subject matches upstream N/A QCLINUX: prefix indicates vendor-only change
Body preserves rationale Clear description of what is being added
Fixes tag present/correct N/A Not a fix; new feature addition
Authorship preserved Author: Milen Mitkov mmitkov@qti.qualcomm.com
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/talos-camera-sensor.dtsi ⚠️ Uses status = "ok" instead of status = "okay" (non-standard); deserializer node missing compatible property

Issues

Device Tree Style Issues:

  1. Non-standard status value: Lines 56 and 75 use status = "ok" instead of the standard status = "okay". While some drivers may accept "ok", the device tree specification and kernel convention use "okay".

  2. Missing compatible property: The qcom,cam-gmsl-deserializer0 node (starting at line 147) lacks a compatible property. Device tree nodes should have a compatible string to bind to a driver. The sensor node has compatible = "qcom,cam-gmsl-sensor", but the deserializer node does not.

  3. Vendor-specific node naming: Node names like qcom,cam-gmsl-deserializer0 and qcom,cam-gmsl-sensor0 use vendor prefixes in the node name itself, which is unconventional. Standard practice is to use generic node names (e.g., camera-deserializer@2) with vendor-specific compatible strings.

Verdict

This is a vendor-only patch (QCLINUX: prefix) adding camera hardware support to the Talos device tree. The patch should be updated to use status = "okay" instead of status = "ok" and should add a compatible property to the deserializer node for proper driver binding. Consider using standard device tree node naming conventions.

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit

@qlijarvis

Copy link
Copy Markdown

PR #643 — checker-log-analyzer

PR: #643
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/27708248934

Checker Result Summary
Checker Result Summary
checkpatch Undocumented DT compatible string
dt-binding-check No binding changes
dtb-check reg_format warning + schema validation failures
sparse-check ⏭️ Skipped (no C code changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance Missing required subject prefix
tag-check N/A Not applicable for this branch
qcom-next-check N/A Not applicable for this branch

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #643 - QCLINUX: arm64: dts: qcom: talos: Add GMSL deserializer and sensor
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/27708248934

Checker Result Summary
checkpatch Undocumented DT compatible string
dt-binding-check No binding changes
dtb-check reg_format warning + schema validation failures
sparse-check ⏭️ Skipped (no C code changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance Missing required subject prefix
tag-check N/A Not applicable for this branch
qcom-next-check N/A Not applicable for this branch

❌ checkpatch

Root cause: The compatible string qcom,cam-gmsl-sensor is used in the DTS but has no corresponding devicetree binding documentation.

Failure details:

WARNING: DT compatible string "qcom,cam-gmsl-sensor" appears un-documented -- check ./Documentation/devicetree/bindings/
#72: FILE: arch/arm64/boot/dts/qcom/talos-camera-sensor.dtsi:191:
+		compatible = "qcom,cam-gmsl-sensor";

f2ba68bcdcb47f3569ad21394d8520dad1366d16 total: 0 errors, 1 warnings, 0 checks, 64 lines checked

Fix:

  1. Add a devicetree binding YAML schema at Documentation/devicetree/bindings/media/qcom,cam-gmsl-sensor.yaml documenting the qcom,cam-gmsl-sensor compatible string, or
  2. If this is a vendor-specific downstream node, consider using a more specific compatible string that references existing documentation, or
  3. If the binding already exists upstream, ensure it's merged into your base branch

Reproduce locally:

./scripts/checkpatch.pl --strict --summary-file --ignore FILE_PATH_CHANGES --git 3b31895064bd0f2ef9b30bfb38e42c9b2692da95..a0c4869336373436610fc5bdbeb398a4de9ff085

❌ dtb-check

Root cause: The port@0 node under qcom,cam-gmsl-deserializer0 has a reg property with incorrect length (4 bytes) when the parent expects #address-cells = 2 and #size-cells = 1 (12 bytes total).

Failure details:

../arch/arm64/boot/dts/qcom/talos-camera-sensor.dtsi:179.4-14: Warning (reg_format): 
/fragment@0/__overlay__/qcom,cci@ac4a000/qcom,cam-gmsl-deserializer0/port@0:reg: 
property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)

arch/arm64/boot/dts/qcom/qcs615-ride-camx.dtb: /soc@0/qcom,cci@ac4a000/qcom,cam-gmsl-sensor0: 
failed to match any schema with compatible: ['qcom,cam-gmsl-sensor']

qcom,cam-gmsl-sensor0 (qcom,cam-gmsl-sensor): status: 'oneOf' conditional failed, one must be fixed:
qcom,cam-gmsl-deserializer0: status: 'oneOf' conditional failed, one must be fixed:

Fix:

  1. Fix the reg property format in port@0: The parent node (qcom,cam-gmsl-deserializer0) is missing explicit #address-cells and #size-cells declarations, causing it to inherit from the parent CCI node which likely has #address-cells = <2> and #size-cells = <1>. You need to either:

    • Add #address-cells = <1>; #size-cells = <0>; to the deserializer node before the port@0 declaration, OR
    • Change reg = <0>; to match the parent's cell sizes (e.g., reg = <0 0 0>; for 2 address cells + 1 size cell)
  2. Add the missing DT binding schema (same as checkpatch issue above) to resolve the "failed to match any schema" errors

  3. Fix the status property: The nodes use status = "ok"; which should be status = "okay"; per devicetree specification

Reproduce locally:

make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/media/
# Or build specific DTBs:
make arch/arm64/boot/dts/qcom/talos-evk-camx.dtb
make arch/arm64/boot/dts/qcom/qcs615-ride-camx.dtb

❌ check-patch-compliance

Root cause: The commit subject line uses QCLINUX: prefix, but the checker expects commits to use standard upstream prefixes like UPSTREAM:, FROMLIST:, BACKPORT:, or FROMGIT: for patches originating from upstream sources.

Failure details:

Checking commit: QCLINUX: arm64: dts: qcom: talos: Add GMSL deserializer and sensor
Commit summary does not start with a required prefix
Process completed with exit code 1.

Fix:
The QCLINUX: prefix is typically used for downstream-only changes. If this patch:

  • Is a downstream-only change: This checker failure may be expected for the target branch. Check if check-patch-compliance should be enforced for your branch.
  • Should use a different prefix: If this is based on or intended for upstream, use the appropriate prefix:
    • UPSTREAM: - for patches already merged in mainline
    • FROMLIST: - for patches posted to mailing lists but not yet merged
    • BACKPORT: - for patches backported from a newer kernel version
    • FROMGIT: - for patches from a maintainer tree not yet in mainline

Reproduce locally:

# Check the compliance script requirements
git log --oneline 3b31895064bd0f2ef9b30bfb38e42c9b2692da95..HEAD

Verdict

3 blockers must be fixed:

  1. Critical: Fix the reg property format in port@0 node (add #address-cells/#size-cells to deserializer node)
  2. Critical: Change status = "ok" to status = "okay" in both new nodes
  3. Required: Add devicetree binding documentation for qcom,cam-gmsl-sensor or verify if check-patch-compliance applies to this branch
  4. Optional: Verify if the QCLINUX: prefix is appropriate for the target branch, or use an upstream-compliant prefix

The dtb-check failures are the most critical as they indicate structural issues with the devicetree that could cause runtime problems.

@qcomlnxci

Copy link
Copy Markdown

Test Matrix

Test Case lemans-evk monaco-evk qcs615-ride qcs6490-rb3gen2 qcs8300-ride qcs9100-ride-r3 x1e80100-crd
BT_FW_KMD_Service ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️
BT_ON_OFF ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️
BT_SCAN ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️
CPUFreq_Validation ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️
CPU_affinity ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️
DSP_AudioPD ✅ Pass ✅ Pass ⚠️ skip ◻️ ✅ Pass ⚠️ skip ◻️
Ethernet ⚠️ skip ✅ Pass ⚠️ skip ◻️ ⚠️ skip ⚠️ skip ◻️
Freq_Scaling ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️
GIC ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️
IPA ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️
Interrupts ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️
OpenCV ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️
PCIe ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️
Probe_Failure_Check ❌ Fail ❌ Fail ❌ Fail ◻️ ❌ Fail ❌ Fail ◻️
RMNET ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️
UFS_Validation ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️
USBHost ❌ Fail ❌ Fail ❌ Fail ◻️ ❌ Fail ❌ Fail ◻️
WiFi_Firmware_Driver ❌ Fail ❌ Fail ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️
WiFi_OnOff ✅ Pass ❌ Fail ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️
adsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ❌ Fail ◻️
cdsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ❌ Fail ◻️
gpdsp_remoteproc ✅ Pass ✅ Pass ⚠️ skip ◻️ ✅ Pass ❌ Fail ◻️
hotplug ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️
irq ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️
kaslr ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️
pinctrl ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️
qcom_hwrng ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️
remoteproc ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ❌ Fail ◻️
rngtest ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️
shmbridge ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️
smmu ❌ Fail ✅ Pass ❌ Fail ◻️ ✅ Pass ❌ Fail ◻️
watchdog ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️
wpss_remoteproc ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass ✅ Pass ◻️

@qlijarvis

Copy link
Copy Markdown

PR #643 — validate-patch

PR: #643

Verdict Issues Detailed Report
0 Full report

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit
Verdict: ✅ — click to expand

🔍 Patch Validation

PR: #643 - QCLINUX: arm64: dts: qcom: talos: Add GMSL deserializer and sensor
Upstream commit: N/A (vendor-only)
Verdict: ✅ PASS

Commit Message

Check Status Note
Subject matches upstream N/A QCLINUX: vendor-only commit
Body preserves rationale Clear description of hardware being added
Fixes tag present/correct N/A New feature, no bug fix
Authorship preserved Milen Mitkov with proper corporate email
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/talos-camera-sensor.dtsi Adds GMSL deserializer and sensor nodes; additive change only

Verdict

Merge as-is — vendor-only device tree addition with proper commit message format and authorship.

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit

@qlijarvis

Copy link
Copy Markdown

PR #643 — checker-log-analyzer

PR: #643
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/27741275925

Checker Result Summary
Checker Result Summary
checkpatch ⚠️ 1 warning: undocumented DT compatible string
dt-binding-check No binding changes
dtb-check Multiple DT validation errors in new nodes
sparse-check ⏭️ Skipped (no C code changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance Subject prefix violation
tag-check N/A Not applicable for internal tree
qcom-next-check N/A Not applicable (QCLINUX prefix)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #643 - QCLINUX: arm64: dts: qcom: talos: Add GMSL deserializer and sensor
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/27741275925

Checker Result Summary
checkpatch ⚠️ 1 warning: undocumented DT compatible string
dt-binding-check No binding changes
dtb-check Multiple DT validation errors in new nodes
sparse-check ⏭️ Skipped (no C code changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance Subject prefix violation
tag-check N/A Not applicable for internal tree
qcom-next-check N/A Not applicable (QCLINUX prefix)

❌ check-patch-compliance

Root cause: Commit subject uses QCLINUX: prefix instead of required UPSTREAM: or FROMLIST: prefix.

Failure details:

Checking commit: QCLINUX: arm64: dts: qcom: talos: Add GMSL deserializer and sensor
Commit summary does not start with a required prefix

Fix: This check enforces that commits must use either UPSTREAM: (for patches already merged in mainline) or FROMLIST: (for patches posted to mailing lists but not yet merged). Since this appears to be a downstream-only change for Qualcomm's internal tree, you have two options:

  1. If this is intended for internal use only: Request an exemption or disable this checker for the PR
  2. If this should go upstream: Post the patch to the appropriate mailing list (devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org) first, then update the subject to FROMLIST: arm64: dts: qcom: talos: Add GMSL deserializer and sensor

Reproduce locally:

# This checker validates commit message prefixes
git log --oneline -1

❌ dtb-check

Root cause: New device tree nodes violate DT schema validation rules for address/size cells and graph port properties.

Failure details:

../arch/arm64/boot/dts/qcom/talos-camera-sensor.dtsi:179.4-14: Warning (reg_format): 
  /fragment@0/__overlay__/qcom,cci@ac4a000/qcom,cam-gmsl-deserializer0/port@0:reg: 
  property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)

../arch/arm64/boot/dts/qcom/talos-camera-sensor.dtsi:147.30-186.4: Warning (avoid_default_addr_size): 
  /fragment@0/__overlay__/qcom,cci@ac4a000/qcom,cam-gmsl-deserializer0: 
  Relying on default #address-cells value

../arch/arm64/boot/dts/qcom/talos-camera-sensor.dtsi:180.4-25: Warning (graph_port): 
  /fragment@0/__overlay__/qcom,cci@ac4a000/qcom,cam-gmsl-deserializer0/port@0:#address-cells: 
  graph node '#address-cells' is -1, must be 1

../arch/arm64/boot/dts/qcom/talos-camera-sensor.dtsi:181.4-22: Warning (graph_port): 
  /fragment@0/__overlay__/qcom,cci@ac4a000/qcom,cam-gmsl-deserializer0/port@0:#size-cells: 
  graph node '#size-cells' is -1, must be 0

arch/arm64/boot/dts/qcom/talos-evk-camx.dtb: /soc@0/qcom,cci@ac4a000/qcom,cam-gmsl-sensor0: 
  failed to match any schema with compatible: ['qcom,cam-gmsl-sensor']

Fix: The new qcom,cam-gmsl-deserializer0 and qcom,cam-gmsl-sensor0 nodes have several issues:

  1. Missing #address-cells and #size-cells in deserializer node (line 147):

    qcom,cam-gmsl-deserializer0 {
    +	#address-cells = <1>;
    +	#size-cells = <0>;
    	cell-index = <2>;
    	...
  2. Port@0 reg property format (line 179): The reg = <0>; is correct for a port node when parent has #address-cells = <1> and #size-cells = <0>, but the parent node needs those properties defined first.

  3. Graph port #address-cells/#size-cells (lines 180-181): These should be set correctly in the port node:

    port@0 {
    	reg = <0>;
    -	#address-cells = <1>;
    -	#size-cells = <0>;
    	deser0_port0: endpoint {
    		remote-endpoint = <&gmsl_sensor0_ep>;
    	};
    };

    Actually, for a port with a single endpoint, you don't need #address-cells/#size-cells. Remove them.

  4. Missing #address-cells and #size-cells in sensor node (line 189):

    qcom,cam-gmsl-sensor0 {
    +	#address-cells = <1>;
    +	#size-cells = <0>;
    	cell-index = <3>;
    	...

Reproduce locally:

make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/
# Or specifically:
make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- qcs615-ride-camx.dtb talos-evk-camx.dtb

⚠️ checkpatch

Root cause: The compatible string "qcom,cam-gmsl-sensor" is not documented in devicetree bindings.

Failure details:

WARNING: DT compatible string "qcom,cam-gmsl-sensor" appears un-documented 
  -- check ./Documentation/devicetree/bindings/
#70: FILE: arch/arm64/boot/dts/qcom/talos-camera-sensor.dtsi:191:
+		compatible = "qcom,cam-gmsl-sensor";

Fix: Add a device tree binding document for this new compatible string:

  1. Create Documentation/devicetree/bindings/media/qcom,cam-gmsl-sensor.yaml
  2. Document the properties used by this node (cell-index, csiphy-sd-index, status, port, etc.)
  3. Follow the DT schema format used by other camera sensor bindings in the kernel

Alternatively, if this is a downstream-only binding that won't go upstream, you may suppress this warning, but it's better practice to document all bindings.

Reproduce locally:

./scripts/checkpatch.pl --strict --git HEAD~1..HEAD

Verdict

3 blockers must be fixed before merge:

  1. check-patch-compliance: Update commit subject prefix to FROMLIST: or UPSTREAM: (or request exemption for internal-only change)
  2. dtb-check: Add #address-cells and #size-cells properties to both qcom,cam-gmsl-deserializer0 and qcom,cam-gmsl-sensor0 nodes, and remove them from the port@0 node
  3. checkpatch warning: Document the qcom,cam-gmsl-sensor compatible string in Documentation/devicetree/bindings/ or suppress if downstream-only

The dtb-check failures are the most critical as they indicate structural DT errors that will cause validation failures and potentially runtime issues.

@qcomlnxci

Copy link
Copy Markdown

Test Matrix

Test Case lemans-evk monaco-evk qcs615-ride qcs6490-rb3gen2 qcs8300-ride qcs9100-ride-r3 x1e80100-crd
BT_FW_KMD_Service ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
BT_ON_OFF ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
BT_SCAN ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
CPUFreq_Validation ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
CPU_affinity ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
DSP_AudioPD ✅ Pass ✅ Pass ⚠️ skip ✅ Pass ✅ Pass ⚠️ skip ◻️
Ethernet ⚠️ skip ✅ Pass ⚠️ skip ⚠️ skip ⚠️ skip ⚠️ skip ◻️
Freq_Scaling ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
GIC ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
IPA ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
Interrupts ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
OpenCV ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
PCIe ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
Probe_Failure_Check ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ◻️
RMNET ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
UFS_Validation ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
USBHost ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ◻️
WiFi_Firmware_Driver ❌ Fail ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
WiFi_OnOff ✅ Pass ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
adsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
cdsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
gpdsp_remoteproc ✅ Pass ✅ Pass ⚠️ skip ⚠️ skip ✅ Pass ❌ Fail ◻️
hotplug ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
irq ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
kaslr ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
pinctrl ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
qcom_hwrng ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
rngtest ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
shmbridge ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
smmu ❌ Fail ✅ Pass ❌ Fail ✅ Pass ✅ Pass ❌ Fail ◻️
watchdog ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
wpss_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️

Comment thread arch/arm64/boot/dts/qcom/talos-camera-sensor.dtsi Outdated
Comment thread arch/arm64/boot/dts/qcom/talos-camera-sensor.dtsi Outdated
Adds deserializer and camera sensor nodes to the Talos device tree.
Talos features a single GMSL deserializer and exposes
a single GMSL camera.

Signed-off-by: Milen Mitkov <mmitkov@qti.qualcomm.com>
@mmitkovquicinc

Copy link
Copy Markdown
Author

Nodes moved alphabetically

@qcomlnxci

Copy link
Copy Markdown

Test Matrix

Test Case lemans-evk monaco-evk qcs615-ride qcs6490-rb3gen2 qcs8300-ride qcs9100-ride-r3 x1e80100-crd
BT_FW_KMD_Service ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
BT_ON_OFF ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
BT_SCAN ✅ Pass ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
CPUFreq_Validation ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
CPU_affinity ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
DSP_AudioPD ✅ Pass ✅ Pass ⚠️ skip ✅ Pass ✅ Pass ⚠️ skip ◻️
Ethernet ⚠️ skip ✅ Pass ⚠️ skip ⚠️ skip ⚠️ skip ⚠️ skip ◻️
Freq_Scaling ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
GIC ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
IPA ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
Interrupts ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
OpenCV ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
PCIe ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
Probe_Failure_Check ❌ Fail ❌ Fail ✅ Pass ❌ Fail ❌ Fail ❌ Fail ◻️
RMNET ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
UFS_Validation ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
USBHost ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ◻️
WiFi_Firmware_Driver ❌ Fail ❌ Fail ❌ Fail ✅ Pass ✅ Pass ✅ Pass ◻️
WiFi_OnOff ✅ Pass ❌ Fail ⚠️ skip ✅ Pass ✅ Pass ✅ Pass ◻️
adsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
cdsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
gpdsp_remoteproc ✅ Pass ✅ Pass ⚠️ skip ⚠️ skip ✅ Pass ❌ Fail ◻️
hotplug ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
irq ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
kaslr ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
pinctrl ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
qcom_hwrng ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail ◻️
rngtest ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
shmbridge ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
smmu ❌ Fail ✅ Pass ❌ Fail ✅ Pass ✅ Pass ❌ Fail ◻️
watchdog ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
wpss_remoteproc ✅ Pass ✅ Pass ⚠️ skip ✅ Pass ✅ Pass ✅ Pass ◻️

@sgaud-quic
Salendarsingh Gaud (sgaud-quic) merged commit f827551 into qualcomm-linux:qcom-6.18.y Jun 18, 2026
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants